Skip to content

TST: add test for duplicated frame/test_analytics #21898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 16, 2018
Merged

TST: add test for duplicated frame/test_analytics #21898

merged 4 commits into from
Jul 16, 2018

Conversation

h-vetinari
Copy link
Contributor

@h-vetinari h-vetinari commented Jul 13, 2018 •
edited
Loading

Preparation for #21645

Added some parametrised tests for duplicated.

In addition, I reordered the tests slightly. Currently, the tests in tests/frame/test_analytics.py test the following functions in order:

drop_duplicates
duplicated
duplicated
drop_duplicates
drop_duplicates
[...]

Since I am (and will be) adding several tests for duplicated, I'd like to group them within the code, and moved the two existing tests for duplicated to the top of that section.

@h-vetinari h-vetinari force-pushed the tst_frame_analytics branch from 1fba88c to 27a2bb7 Compare July 13, 2018 20:56
@h-vetinari h-vetinari changed the title TST/CLN: group tests in frame/test_analytics; prep for #21645 TST: add test for duplicated frame/test_analytics Jul 13, 2018
@h-vetinari h-vetinari mentioned this pull request Jul 13, 2018
Closed
@h-vetinari
Copy link
Contributor Author

One single test failure in 1/7 jobs is unrelated:

E           AssertionError: Caused unexpected warning(s): [('ResourceWarning',
ResourceWarning("unclosed file <_io.BufferedReader name='/var/folders/bb/n7t3rs157850byt_jfdcq9k80000gn/T/tmptvrq0c3stest_file.zip'>",),
'/Users/travis/miniconda3/envs/pandas/lib/python3.5/site-packages/pluggy/__init__.py', 139)].

@jreback jreback added the Testing pandas testing functions or related to the test suite label Jul 14, 2018
@jreback
Copy link
Contributor

jreback commented Jul 14, 2018 •
edited
Loading

can you move the duplicated test into a new file frame/test_duplicates. same for series (you can move unique too as well)

@jreback jreback added this to the 0.24.0 milestone Jul 14, 2018
@jreback jreback added the Clean label Jul 14, 2018
@codecov
Copy link

codecov bot commented Jul 14, 2018 •
edited
Loading

Codecov Report

Merging #21898 into master will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #21898      +/-   ##
==========================================
+ Coverage   91.91%   91.96%   +0.05%     
==========================================
  Files         164      166       +2     
  Lines       49992    50323     +331     
==========================================
+ Hits        45951    46281     +330     
- Misses       4041     4042       +1
Flag Coverage Δ
#multiple 90.36% <ø> (+0.06%) ⬆️
#single 42.23% <ø> (+0.07%) ⬆️
Impacted Files Coverage Δ
pandas/core/indexes/timedeltas.py 91.53% <0%> (-0.65%) ⬇️
pandas/core/indexes/base.py 96.35% <0%> (-0.23%) ⬇️
pandas/core/indexes/datetimes.py 95.16% <0%> (-0.18%) ⬇️
pandas/core/algorithms.py 94.69% <0%> (-0.16%) ⬇️
pandas/io/packers.py 88.04% <0%> (-0.16%) ⬇️
pandas/core/dtypes/common.py 95.07% <0%> (ø) ⬆️
pandas/core/arrays/__init__.py 100% <0%> (ø) ⬆️
pandas/core/dtypes/inference.py 98.41% <0%> (ø) ⬆️
pandas/core/arrays/timedelta.py
pandas/core/arrays/timedeltas.py 89.84% <0%> (ø)
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 365eac4...9d428e2. Read the comment docs.

jreback
jreback approved these changes Jul 14, 2018
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@h-vetinari h-vetinari mentioned this pull request Jul 14, 2018
Merged
@jreback jreback merged commit 15dbd19 into pandas-dev:master Jul 16, 2018
@jreback
Copy link
Contributor

jreback commented Jul 16, 2018

thanks @h-vetinari

@h-vetinari h-vetinari deleted the tst_frame_analytics branch July 17, 2018 07:18
aeltanawy pushed a commit to aeltanawy/pandas that referenced this pull request Jul 20, 2018
@h-vetinari @aeltanawy
TST: add test for duplicated frame/test_analytics (pandas-dev#21898)
04b6bce
Sup3rGeo pushed a commit to Sup3rGeo/pandas that referenced this pull request Oct 1, 2018
@h-vetinari
TST: add test for duplicated frame/test_analytics (pandas-dev#21898)
650ac16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback approved these changes

Assignees
No one assigned
Labels
Clean Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
0.24.0
Development

Successfully merging this pull request may close these issues.
2 participants
@h-vetinari @jreback